Remove ld and ar from tools.build:compiler_executables
#16647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 10, 2024
AbrilRBS
approved these changes
Jul 10, 2024
czoido
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Please, check the gnutolchain I think we are using ar and ld there.
|
@ErniGH Yes, remove from the GnuToolchain that part too. I have no objection to keeping the same mapping there as it's done in the AutotoolsToolchain. |
czoido
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Remove unsupported
ldandarentries fromtools.build:compiler_executables, they had no effect in every Conan integration.Docs: Omit
Normally, people use the environment variables provided by each toolchain to introduce
arandld. Additionally, no Conan toolchain implements eitherarorldfromtools.build:compiler_executables. Therefore, I believe it is better to remove these variables to avoid future problems.Close: #16517