Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClangCL platform toolset in MSBuildToolchain generator when compi… #16844

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Aug 19, 2024

Changelog: Bugfix: When using Visual Studio's llvm-clang, set the correct Platform Toolset in MSBuildToolchain.
Docs: Omit

When building msvc-compatible binaries using the Clang distribution in Visual Studio, set the correct Platform toolset when using MSBuildToolchain.

From: https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/tools-pc/visualstudio/gr-vs-clang
Screenshot 2024-08-19 at 10 43 32

@jcar87 jcar87 requested a review from memsharded August 19, 2024 09:44
@memsharded
Copy link
Member

I have double checked conan-center-index, and all usages of msvs_toolset are protected by is_msvc(), so we are safe there.

Docs in https://docs.conan.io/2/reference/tools/microsoft/helpers.html#msvs-toolset would need an update probably, they are not very clear, I suggest updating the docstring of msvs_toolset in this PR

@memsharded memsharded added this to the 2.7.0 milestone Aug 19, 2024
@memsharded memsharded self-assigned this Aug 20, 2024
@memsharded memsharded merged commit ce22792 into conan-io:develop2 Aug 20, 2024
2 checks passed
@jcar87 jcar87 deleted the lcc/bugfix/clang-cl-msbuild-platform-toolset branch August 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants