Fix for #16882: Generated CMake build when using tools.build.linker_scripts #16883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated build otherwise appends the "-Tfoo.ld" argument directly without a preceding space before which can generate an invalid command line.
``` CMake Warning (dev) at /home/chipc/.conan2/p/b/mypkgbc25b469ad9ce/b/build/generators/conan_toolchain.cmake:54: Syntax Warning in cmake code at column 43 Argument not separated from preceding token by whitespace. ```
photex
force-pushed
the
dev/chip/cmake_linker_scripts
branch
from
2c531e1 to
09d3616
Compare
memsharded
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Thanks very much for your contribution @photex
You are right, there is a bug there, and the extra space is necessary.
It would be necessary to add some unit or integration test for this, to make sure this is covered and don't break again in the future. I can also try to help with this.
|
I have pushed some changes, fixing the test (that test will cover the change already), and trying to keep the original quotes. Can you please test this branch with your build to see if it works? Thanks! |
|
@memsharded you're update fixed the cmake warnings I was seeing as well. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated build otherwise appends the "-Tfoo.ld" argument directly without a preceding space before which can generate an invalid command line.
Changelog: Bugfix: Avoid
CMakeToolchainerror when both architecture flags andtools.build:linker_scriptsare defined, due to missing space.Docs: Omit
Close #16882
developbranch, documenting this one.