Fix/rest #17083
Merged
Fix/rest #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Sep 30, 2024
AbrilRBS
approved these changes
Oct 4, 2024
|
|
||
| # If not found, then interactive prompt | ||
| ui = UserInput(self._global_conf.get("core:non_interactive", check_type=bool)) | ||
| input_user, input_password = ui.request_login(remote.name, user) | ||
| return input_user, input_password | ||
| return input_user, input_password, True |
There was a problem hiding this comment.
Seems like UserInput throws if core:non_interactive is True, so at this point we're always interactive 👍
czoido
approved these changes
Oct 7, 2024
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Oct 7, 2024
* fixing Rest layer * wip * fix test * caching localdb creds and capabilities
memsharded
added a commit
that referenced
this pull request
Oct 7, 2024
* refactor, cleaning exceptions * Add support for including paths that are ignored in `.conanignore` (#17123) * Add support for including paths that are ignored in .conanignore * Improve include check performance * Cleanuo * Fix/rest (#17083) * fixing Rest layer * wip * fix test * caching localdb creds and capabilities * fix tests * review --------- Co-authored-by: Abril Rincón Blanco <rubenrb@jfrog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid repeated login attempts to the server for 401 when the credentials come from env-vars or
credentials.jsonfile, only repeated login attempts for user interactive prompt.Docs: Omit
Internal refactor:
oauthauthentication and the refresh_token functionality, it was dead code in practice as server side never implemented this, not conan_server, neither Artifactoryv1/pingcalls to remotes.