Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC for tool_requires that make direct dependees inherit generators #17129

Merged
merged 9 commits into from
Oct 23, 2024
Merged

POC for tool_requires that make direct dependees inherit generators #17129

merged 9 commits into from
Oct 23, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Oct 8, 2024 •
edited by czoido
Loading

Changelog: Feature: Add self.generators_info for tool_requires to propagate generators to their direct dependencies.
Docs: conan-io/docs#3880

To share as idea for the team

Close #17113

@AbrilRBS AbrilRBS requested a review from memsharded October 8, 2024 11:01
@memsharded memsharded self-assigned this Oct 8, 2024
memsharded
memsharded reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Some minor tests suggestions

test/integration/generators/test_generators_from_br.py Outdated Show resolved Hide resolved
test/integration/generators/test_generators_from_br.py Outdated Show resolved Hide resolved
memsharded
memsharded approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@memsharded memsharded mentioned this pull request Oct 11, 2024
Closed
1 task
@AbrilRBS AbrilRBS marked this pull request as ready for review October 14, 2024 10:06
@ErniGH ErniGH modified the milestone: 2.9.0 Oct 14, 2024
@AbrilRBS AbrilRBS added this to the 2.9.0 milestone Oct 15, 2024
memsharded
memsharded approved these changes Oct 23, 2024
View reviewed changes
conan/internal/api/install/generators.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit aefacdc into conan-io:develop2 Oct 23, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the ar/tool-requires-generator-poc branch October 28, 2024 10:08
@AbrilRBS AbrilRBS mentioned this pull request Oct 28, 2024
Merged
@X1aomu X1aomu mentioned this pull request Nov 20, 2024
Closed
1 task
@memsharded memsharded mentioned this pull request Dec 2, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

How to tell consumers to use specific generator?
3 participants
@AbrilRBS @memsharded @ErniGH