-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quote template CMake variables #17156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! I wish I had figured this would be a possibility when adding it!
Maybe adding a simple test for this would be great, let us know if you need help with that :)
This fix addresses an issue where "cppstd" is undefined for pure C recipes. Consequently, "set" sometimes leaves the "conan_watched_std_variable" unset, leading to an error in the subsequent string comparison: ``` CMake Error at .../conan_toolchain.cmake:64 (if): if given arguments: "READ_ACCESS" "STREQUAL" "MODIFIED_ACCESS" "AND" "NOT" "11" "STREQUAL" Unknown arguments specified ```
Done. |
Thanks @skycaptain - The test also uncovered a bug in the cstd error reporting, so that's 2 for 1! Either way, I'm proposing #17157 to fix the cstd error while removing some slight duplication |
The current test error is due to a missconfiguration for functional tests on our side:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for these fixes @skycaptain !
I'll fix the test.
Changelog: Bugfix: Fix cppstd/cstd
variable_watch
when they are not defined.Changelog: Bugfix: Fix cstd error reporting when a recipe does not support the required version.
Docs: Omit
This fix addresses an issue where "cppstd" is undefined for pure C recipes. Consequently, "set" sometimes leaves the
"conan_watched_std_variable" unset, leading to an error in the subsequent string comparison:
develop
branch, documenting this one.