[Bazel] Adding Bazel startup options #17183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvolx
approved these changes
Oct 19, 2024
czoido
reviewed
Oct 28, 2024
conan/tools/google/bazel.py
Outdated
| @@ -77,4 +79,4 @@ def test(self, target=None): | |||
| """ | |||
| if self._conanfile.conf.get("tools.build:skip_test", check_type=bool) or target is None: | |||
| return | |||
| self._safe_run_command(f'bazel test {target}') | |||
| self._safe_run_command(f"{self._bazel_base_command} test {target}") | |||
There was a problem hiding this comment.
I think this would be cleaner if it was something like:
self._safe_run_command(f"bazel {self._get_startup_command_options()} test {target}")
And the same for build and clean
czoido
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Adding the startup options to each Bazel command.
Closes: #17101
Docs: omit