Add --output option to conan new command
#17359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-------------------------- Co-authored-by: PerseoGI <perseog@jfrog.com>
perseoGI
approved these changes
Nov 21, 2024
memsharded
reviewed
Nov 21, 2024
AbrilRBS
changed the title
--output-folder option to conan new command--output option to conan new command
AbrilRBS
commented
Nov 21, 2024
| @@ -93,9 +93,11 @@ def _read_files(self, template_folder): | |||
| @staticmethod | |||
| def render(template_files, definitions): | |||
| result = {} | |||
| name = definitions.get("name", "Pkg") | |||
| name = definitions.get("name", "pkg") | |||
There was a problem hiding this comment.
When no name was passed, an uppercase one was being used!
memsharded
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add
--outputoption toconan newcommand.Docs: Omit
We found that it was usueful when creating a mock multiproject
Only thing is that we recently removed the conan new command tests, and there's no good place to add one now :(.
I can confirm that it works locally for me though