Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMakeToolchain] fix adding tools.android:ndk_path with spaces in path #17379

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

kambala-decapitator
Copy link
Contributor

@kambala-decapitator kambala-decapitator commented Nov 25, 2024

Changelog: Bugfix: Fix adding tools.android:ndk_path with spaces in path.
Docs: Omit

Closes: #17378

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Test test_android_c_library is broken in CI, it seems it is testing the output literally, so it should be updated.

@memsharded memsharded added this to the 2.10.0 milestone Nov 25, 2024
@kambala-decapitator
Copy link
Contributor Author

thanks, you're absolutely right! Updated the test.

@memsharded memsharded merged commit aa4920e into conan-io:develop2 Nov 26, 2024
2 checks passed
@kambala-decapitator kambala-decapitator deleted the patch-1 branch November 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] NDK path with spaces doesn't work in CMakeToolchain
4 participants