[AutotoolsToolchain] Improve Android cross-compilation UX #17470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
changed the title
franramirez688
changed the title
valgur
reviewed
Dec 16, 2024
franramirez688
commented
Dec 17, 2024
| @@ -69,10 +69,8 @@ def __init__(self, conanfile, namespace=None, prefix="/"): | |||
| # If cross-building and tools.android:ndk_path is defined, let's try to guess the Android | |||
| # cross-building flags | |||
| self.android_cross_flags = self._resolve_android_cross_compilation() | |||
| # Host triplet | |||
| if self.android_cross_flags: | |||
| self._host = self.android_cross_flags.pop("host") | |||
There was a problem hiding this comment.
memsharded
approved these changes
Dec 17, 2024
memsharded
approved these changes
Dec 18, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature:
AutotoolsToolchainuses user's variables when Android cross-compilation at first.Changelog: Feature:
AutotoolsToolchainchecks if Android cross-compilation paths exist.Docs: conan-io/docs#3951
Closes: #17441
Closes: #16809