Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MakeDeps example #115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Aug 29, 2023

Some of Poco deps requires GCC >=7

  • Tested locally on Linux
  • Tested locally on OSX
  • Tested locally on Windows

No support for Windows now, let's postpone it as will require msys2

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries marked this pull request as ready for review August 29, 2023 10:57
@uilianries
Copy link
Member Author

It fails because MakeDeps is not available yet in current version.

@uilianries
Copy link
Member Author

We can not use Poco, because we will need C++17:

libmysqlclient/8.0.31: Cannot build for this configuration: Current cppstd (gnu14) is lower than the required C++ standard (17).

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@czoido
Copy link
Contributor

czoido commented Sep 7, 2023

Great! Just a two things:

  • Don't forget to update the README for the corresponding section of the examples2 repo
  • All examples should have a corresponding documentation. Is there a corresponding PR for the docs too?

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

uilianries commented Sep 7, 2023

  • Update the README for the corresponding section of the examples2 repo
  • All examples should have a corresponding documentation.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@czoido Yes, now is everything correct:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants