Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB-H032 hook is outdated #510

Open
maksim-petukhov opened this issue Aug 21, 2023 · 5 comments
Open

KB-H032 hook is outdated #510

maksim-petukhov opened this issue Aug 21, 2023 · 5 comments

Comments

@maksim-petukhov
Copy link

It handles SystemPackageTool which is deprecated and doesn't handle tools under conan.tools.system.package_manager but it should.

@Croydon
Copy link
Contributor

Croydon commented Jun 19, 2024

The hook should probably just forbid to use def system_requirements() altogether outside of system packages

@uilianries
Copy link
Member

We are not touching in Hooks right now, because we are re-writing the CI and Conan 2.x will be main version, so system_requirements() will not be found, resulting in error.

@Croydon
Copy link
Contributor

Croydon commented Oct 22, 2024

System requirements slipped through review in conan-io/conan-center-index#21353 due to unadopted hooks

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 22, 2024

Hi @Croydon thanks for the heads-up. Note that the new hooks are already in place (but not yet visible!) and are able to catch this case just fine, and the recipe was fixed a while back the recipe will be fixed, thanks for the heads-up! :)

@jcar87
Copy link
Contributor

jcar87 commented Oct 22, 2024

Correction on the above - the team has been porting the hooks to Conan 2, and will be rolled in out in a couple of weeks -if everything goes well- coinciding with the deprecation of Conan 1.x

This hook is already ported - will double check that this can now be detected in the new pipeline.

Will look into amending the recipe, but contributions are welcome if this is urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants