Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Do not use cache when installing python requirements #366

Merged
merged 12 commits into from
Oct 22, 2021
Merged

[hotfix] Do not use cache when installing python requirements #366

merged 12 commits into from
Oct 22, 2021

Conversation

uilianries
Copy link
Member

Enforce no cache usage for tox

Related to #365

/cc @ericLemanissier @madebr

@uilianries
Enforce tox update
8b2f1f1 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
No cache install
8fc8834 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested review from jgsogo, danimtb and SSE4 October 21, 2021 16:22
@uilianries uilianries mentioned this pull request Oct 21, 2021
Merged
@uilianries
Update pip after installing
170ee5e 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
SSE4
SSE4 reviewed Oct 21, 2021
View reviewed changes
.ci/generate_env_linux.sh Outdated Show resolved Hide resolved
SSE4
SSE4 reviewed Oct 21, 2021
View reviewed changes
.ci/generate_env_windows.bat Outdated Show resolved Hide resolved
@uilianries
No cache dir when upgrading pip
b86467f 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
tox verbose
899bf42 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
SSE4
SSE4 previously approved these changes Oct 21, 2021
View reviewed changes
@uilianries
recreate env for windows
82f5285 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Revert "recreate env for windows"
2f2caaa 
This reverts commit 82f5285.
@uilianries
remove no-cache-dir
a5bf246 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
revert changes
340ede4 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
separte no-cache-dir
ccc9dff 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Enforce tox to recreate env
72612d3 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
jgsogo
jgsogo reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with using the cache dir (why add --no-cache-dir)? In this context it is harmless to cache the files that pip downloads...

@uilianries
Copy link
Member Author

@jgsogo I'll keep tox recreate only.

@uilianries
preserve cache dir
e7defce 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@danimtb danimtb merged commit 96804ba into conan-io:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@madebr madebr madebr approved these changes

@jgsogo jgsogo jgsogo approved these changes

@SSE4 SSE4 SSE4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uilianries @SSE4 @jgsogo @madebr @danimtb