Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made phone_number optional #47

Merged
merged 1 commit into from
Dec 31, 2017
Merged

Made phone_number optional #47

merged 1 commit into from
Dec 31, 2017

Conversation

Hultner
Copy link
Contributor

@Hultner Hultner commented Dec 29, 2017

This fixes issue #46

I also added and adjusted affected tests as well as added tests for full test coverage of thefbmq/payload.py file.

@Hultner
Made phone_number optional
af565ee 
Added tests for full test coverage of fbmq/payload.py
@coveralls
Copy link

coveralls commented Dec 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 89.8% when pulling af565ee on Hultner:master into c5b40e8 on conbus:master.

@anton-nayshtut anton-nayshtut merged commit ad704b0 into conbus:master Dec 31, 2017
@anton-nayshtut
Copy link
Contributor

Merged and released as 2.4.3

Thanks a lot, @Hultner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hultner @coveralls @anton-nayshtut