hacky untyped fix for the duplicate answers problem #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that the AP code using the storage facade, doesn't update its own answer objects. It is counting on the storage facade to call its answerWatcher callback and then it updates the answer object. So the dexie provider needs to implement the answerWatcher better. The implementation here does does this watching within the current tab. It isn't using dexie observable or something similar to watch for changes across tabs. Also this code isn't supporting the unsubscribing of the watchers. It doesn't look like the AP code is calling this unsubscribe, in the normal case, but it should be.
|
I think @knowuh should do the review on this. |
Codecov Report
@@ Coverage Diff @@
## offline-mode #165 +/- ##
================================================
- Coverage 75.74% 75.31% -0.43%
================================================
Files 91 91
Lines 3187 3205 +18
Branches 717 721 +4
================================================
Hits 2414 2414
- Misses 766 784 +18
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
One more typing fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no tests and isn't typed, but it might be worth merging since it seems to fix a critical bug when demoing this stuff.
I'll leave it up to you to decide.
I think I problem is described pretty well in the story:
https://www.pivotaltracker.com/story/show/177333639
The technical issue is that the host code using the the storage system is assuming that the watchAnswer callback will be called after the createOrUpdateAnswer is complete.