fix: import of v2 documents with maps #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
==========================================
+ Coverage 85.69% 85.74% +0.04%
==========================================
Files 604 604
Lines 30740 30759 +19
Branches 7895 8430 +535
==========================================
+ Hits 26344 26374 +30
+ Misses 4241 4064 -177
- Partials 155 321 +166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 05m 55s |
| Commit |
|
| Committer | Kirk Swenson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
scytacki
approved these changes
Nov 28, 2024
kswenson
force-pushed
the
188620026-fix-v2-map-importer
branch
from
974ce92 to
6d86b2d
Compare
I added jest tests. |
bfinzer
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PT-188620026]
[PT-188614511]
Fixes several issues discovered while importing a number of legacy v2 documents with maps.
Note that it doesn't appear that v2 meaningfully supports the legacy v2 Map format, i.e. most of the properties are ignored and the Map reverts to its default behavior. We follow the same approach for v3, whereby the legacy types are acknowledged but not actually migrated.
Also fixes a v3 bug/limitation which prevented the Map component from supporting points and boundaries from the same data set.