Restore dynamic update of mean adornment #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updating * This bug first appeared in build 1949, in October, 2024. Some update machinery in data-configuration-model.ts was removed around then so `GraphContentModel:updateAdornments` was no longer being called when case values are changed. The only thing that needed to be fixed was to increment the `DataConfigurationModel`'s `casesChangeCount` in `handleSetCaseValues`. Doing so restored the previous behavior with no apparent added cost.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
===========================================
- Coverage 85.78% 67.74% -18.04%
===========================================
Files 604 604
Lines 30737 30738 +1
Branches 8479 8488 +9
===========================================
- Hits 26367 20823 -5544
- Misses 4052 9307 +5255
- Partials 318 608 +290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 05m 51s |
| Commit |
|
| Committer | William Finzer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#188640918] Bug fix: When points in dot plot are dragged, mean isn't updating
GraphContentModel:updateAdornmentswas no longer being called when case values are changed. The only thing that needed to be fixed was to increment theDataConfigurationModel'scasesChangeCountinhandleSetCaseValues. Doing so restored the previous behavior with no apparent added cost.