-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some TODO_V2_IMPORT comments #1694
base: main
Are you sure you want to change the base?
Conversation
…ations of what should be done to address the issue. All relate to properties that are present in V2 documents that have not yet been brought into the V3 document model. About 7 stories have been created based on these markers. But the remainder are all in codap-v2-types.ts and can be dealt with in situ. Here is a rough classification. * Properties that were present briefly in V2 documents but are no longer used. These can be ignored in the V3 import. * Properties that are also present in V3 and which refer to implemented features, but the carrying them over during the input process has not yet been brought about. * Properties present in the V3 model which do not yet have an implementation. * Properties not present in V3 but where the feature is present but defined differently. An example of this is `transparency` referring to the opacity of a graph point where this is stored as a separate property in V2 but is an intrinsic part of the `fill` of a point in V3. * Properties referring to a feature present in V2 but which is not yet implemented in V3.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
===========================================
- Coverage 85.86% 68.12% -17.75%
===========================================
Files 607 607
Lines 31012 31012
Branches 8603 8594 -9
===========================================
- Hits 26628 21126 -5502
- Misses 4063 9276 +5213
- Partials 321 610 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5597
Run Properties:
|
Project |
codap-v3
|
Branch Review |
update-comments-v2-import-v3
|
Run status |
Passed #5597
|
Run duration | 01m 51s |
Commit |
b3f4536e80: * Explicitly classified ~24 of the TODO_V2_IMPORT comments. ~49 remaining.
|
Committer | William Finzer |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM -- just one potential typo
source?: string | ||
// TODO_V2_IMPORT data context metadata importDate is not imported | ||
// TODO_V2_IMPORT_CARRY_OVER G data context metadata importDate is not imported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO_V2_IMPORT_CARRY_OVER G data context metadata importDate is not imported | |
// TODO_V2_IMPORT_CARRY_OVER data context metadata importDate is not imported |
transparency
referring to the opacity of a graph point where this is stored as a separate property in V2 but is an intrinsic part of thefill
of a point in V3.