Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

181846570 adjustable row height #1700

Merged
merged 9 commits into from
Dec 24, 2024
Merged

Conversation

eireland
Copy link
Contributor

Adds a row divider that acts as a handle for adjusting row heights.
Rows snaps to heights that are multiples of 18 (the default min row height)
Text wraps when row height is taller than minimum row height.
Row height is saved and restored.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 74.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (15ed402) to head (26b11dd).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/case-table/row-divider.tsx 67.85% 17 Missing and 1 partial ⚠️
v3/src/components/case-table/case-table-model.ts 66.66% 2 Missing ⚠️
v3/src/components/case-table/collection-table.tsx 60.00% 2 Missing ⚠️
v3/src/components/case-table/use-rows.ts 0.00% 2 Missing ⚠️
...rc/components/case-table/collection-table-model.ts 83.33% 1 Missing ⚠️
...onents/case-tile-common/attribute-format-utils.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   85.90%   85.77%   -0.13%     
==========================================
  Files         607      608       +1     
  Lines       31055    31135      +80     
  Branches     8621     8645      +24     
==========================================
+ Hits        26677    26706      +29     
+ Misses       4223     4105     -118     
- Partials      155      324     +169     
Flag Coverage Δ
cypress 74.59% <69.04%> (-0.15%) ⬇️
jest 53.84% <44.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 20, 2024

codap-v3    Run #5638

Run Properties:  status check passed Passed #5638  •  git commit 2a73471094: Increment the build number
Project codap-v3
Branch Review main
Run status status check passed Passed #5638
Run duration 01m 51s
Commit git commit 2a73471094: Increment the build number
Committer eireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good -- I pushed a commit which tweaked a few things. Run it through its paces to make sure everything works before merging.

@eireland eireland marked this pull request as ready for review December 23, 2024 23:59
@eireland eireland merged commit 274d1a7 into main Dec 24, 2024
19 of 21 checks passed
@eireland eireland deleted the 181846570-adjustable-row-height branch December 24, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants