-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
181846570 adjustable row height #1700
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
- Coverage 85.90% 85.77% -0.13%
==========================================
Files 607 608 +1
Lines 31055 31135 +80
Branches 8621 8645 +24
==========================================
+ Hits 26677 26706 +29
+ Misses 4223 4105 -118
- Partials 155 324 +169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5638
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #5638
|
Run duration | 01m 51s |
Commit |
2a73471094: Increment the build number
|
Committer | eireland |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good -- I pushed a commit which tweaked a few things. Run it through its paces to make sure everything works before merging.
Adds a row divider that acts as a handle for adjusting row heights.
Rows snaps to heights that are multiples of 18 (the default min row height)
Text wraps when row height is taller than minimum row height.
Row height is saved and restored.