Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v2 slider export #1705

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix: v2 slider export #1705

merged 1 commit into from
Dec 24, 2024

Conversation

kswenson
Copy link
Member

Fix issues found by QA after initial implementation of [PT-188616852]

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (02af839) to head (3cb66a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1705       +/-   ##
===========================================
+ Coverage   68.58%   85.86%   +17.28%     
===========================================
  Files         608      608               
  Lines       31242    31242               
  Branches     8083     8083               
===========================================
+ Hits        21426    26827     +5401     
+ Misses       9661     4260     -5401     
  Partials      155      155               
Flag Coverage Δ
cypress 74.56% <ø> (+31.01%) ⬆️
jest 54.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 24, 2024

codap-v3    Run #5659

Run Properties:  status check passed Passed #5659  •  git commit 822ee371bd: fix: v2 slider export (#1705)
Project codap-v3
Branch Review main
Run status status check passed Passed #5659
Run duration 05m 51s
Commit git commit 822ee371bd: fix: v2 slider export (#1705)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review December 24, 2024 20:27
Copy link
Contributor

@tealefristoe tealefristoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kswenson kswenson merged commit 822ee37 into main Dec 24, 2024
24 checks passed
@kswenson kswenson deleted the 188616852-fix-v2-slider-export branch December 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants