Update MathJS to v12, update formula code to work with fixed special chars in MathJS, add unit tests #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecial chars in MathJS, add unit tests [PT-186376342]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
- Coverage 84.09% 84.09% -0.01%
==========================================
Files 327 327
Lines 13590 13588 -2
Branches 3625 3624 -1
==========================================
- Hits 11429 11427 -2
Misses 2067 2067
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kswenson mentioned that MathJS v11.12.0 is causing Cypress tests to break: #964
This issue happened due to a recent MathJS bug fix:
This PR removes some lines from formula-utils.ts that are no longer necessary. Additionally, I've added unit tests that would fail with MathJS < 11.12.0 and the new code, providing us with double coverage (not just relying on the Cypress tests that saved me before, thanks to @tejal-shah 😉).