Fix positioning of sparrow buttons in Geometry #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
- Coverage 86.13% 85.38% -0.75%
==========================================
Files 746 746
Lines 38663 38664 +1
Branches 9871 9872 +1
==========================================
- Hits 33301 33015 -286
- Misses 5063 5345 +282
- Partials 299 304 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188534586-fix-geometry-sparrows
|
| Run status |
|
| Run duration | 15m 40s |
| Commit |
|
| Committer | Boris Goldowsky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
115
|
| View all changes introduced in this branch ↗︎ | |
|
The regression test failure is just the one that's on master right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by the navigator panel in the Geometry tile.
The navigator-internal
GeometryContentComponentwas re-registering the tileAPI and returning incorrect position information for objects (based on where they are shown in the navigator view, rather than the main tile view).