-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rubric icon and details dialog [PT-187021082] #443
Conversation
1c7b66a
to
9b51b34
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 92.96% 92.43% -0.54%
==========================================
Files 171 173 +2
Lines 6087 6186 +99
Branches 1275 1290 +15
==========================================
+ Hits 5659 5718 +59
- Misses 403 443 +40
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Passing run #1792 ↗︎
Details:
Review all test suite changes for PR #443 ↗︎ |
Features: - Rubric summary icon shows the distribution of scores per aspect of proficiency across the class in the Feedback Panel - Icon updates as scores are entered - If no rubric scores are entered, show N/A in place of the rubric icon in the feedback panel - Rubric summary icon has default, hover, and click states - When clicked, display lightbox dialog of Rubric Summary Details that shows percentages across the class per rating
9b51b34
to
ce5b54e
Compare
js/components/portal-dashboard/feedback/rubric-summary-modal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :) Looks good, just one question about whether or not you meant to keep in a commented-out line of code
Features: