Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rubric icon and details dialog [PT-187021082] #443

Merged
merged 3 commits into from
Mar 7, 2024
Merged

feat: Add rubric icon and details dialog [PT-187021082] #443

merged 3 commits into from
Mar 7, 2024

Conversation

dougmartin
Copy link
Member

@dougmartin dougmartin commented Mar 6, 2024 •
edited
Loading

Features:

  • Rubric summary icon shows the distribution of scores per aspect of proficiency across the class in the Feedback Panel
  • Icon updates as scores are entered
  • If no rubric scores are entered, show N/A in place of the rubric icon in the feedback panel
  • Rubric summary icon has default, hover, and click states
  • When clicked, display lightbox dialog of Rubric Summary Details that shows percentages across the class per rating

@dougmartin dougmartin requested a review from lublagg March 6, 2024 15:30
@dougmartin dougmartin removed the request for review from lublagg March 6, 2024 15:35
@dougmartin dougmartin marked this pull request as draft March 6, 2024 15:36
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.80392% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 92.43%. Comparing base (b2b0c15) to head (be00cf1).
Report is 4 commits behind head on master.

Files Patch % Lines
...portal-dashboard/feedback/rubric-summary-modal.tsx 22.91% 37 Missing ⚠️
...mponents/portal-dashboard/feedback/rubric-utils.ts 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   92.96%   92.43%   -0.54%     
==========================================
  Files         171      173       +2     
  Lines        6087     6186      +99     
  Branches     1275     1290      +15     
==========================================
+ Hits         5659     5718      +59     
- Misses        403      443      +40     
  Partials       25       25
Flag Coverage Δ
cypress 90.71% <59.80%> (-0.52%) ⬇️
jest 62.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Mar 6, 2024 •
edited
Loading

Passing run #1792 ↗︎

0 173 5 0 Flakiness 0

Details:

Removed commented out code and fixed import order
Project: portal-report Commit: be00cf1bb4
Status: Passed Duration: 03:25 💡
Started: Mar 6, 2024 10:52 PM Ended: Mar 6, 2024 10:56 PM

Review all test suite changes for PR #443 ↗︎

@dougmartin
feat: Add rubric icon and details dialog [PT-187021082]
ce5b54e 
Features:

- Rubric summary icon shows the distribution of scores per aspect of proficiency across the class in the Feedback Panel
- Icon updates as scores are entered
- If no rubric scores are entered, show N/A in place of the rubric icon in the feedback panel
- Rubric summary icon has default, hover, and click states
- When clicked, display lightbox dialog of Rubric Summary Details that shows percentages across the class per rating
@dougmartin dougmartin changed the title feat: Add rubric icon [PT-187021082] feat: Add rubric icon and details dialog [PT-187021082] Mar 6, 2024
@dougmartin dougmartin marked this pull request as ready for review March 6, 2024 19:43
@dougmartin dougmartin requested a review from lublagg March 6, 2024 19:43
lublagg
lublagg approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Looks good, just one question about whether or not you meant to keep in a commented-out line of code

@dougmartin dougmartin merged commit 0e665b3 into master Mar 7, 2024
6 of 9 checks passed
@dougmartin dougmartin deleted the 187021082-add-rubric-icon branch March 7, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lublagg lublagg lublagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougmartin @lublagg