Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Average rubric score calculation [PT-187021319] #444

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

dougmartin
Copy link
Member

When a score is removed from the rubric the value is set to 0 and in that case the scored question count should not be increased.

When a score is removed from the rubric the value is set to 0 and in that case the scored question count should not be increased.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (ece3441) to head (fdea516).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files         171      171           
  Lines        6087     6087           
  Branches     1275     1275           
=======================================
  Hits         5659     5659           
  Misses        403      403           
  Partials       25       25           
Flag Coverage Δ
cypress 91.22% <100.00%> (ø)
jest 62.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 6, 2024

Passing run #1789 ↗︎

0 173 5 0 Flakiness 0

Details:

fix: Average rubric score calculation [PT-187021319]
Project: portal-report Commit: fdea5168bd
Status: Passed Duration: 03:26 💡
Started: Mar 6, 2024 8:05 PM Ended: Mar 6, 2024 8:09 PM

Review all test suite changes for PR #444 ↗︎

@dougmartin
Copy link
Member Author

Merging without review as it is a simple one-line change.

@dougmartin dougmartin merged commit ff170f6 into master Mar 6, 2024
9 checks passed
@dougmartin dougmartin deleted the 187021319-fix-avg-score-calc branch March 6, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant