Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add confirmation on max score setting [PT-187021265] #445

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

dougmartin
Copy link
Member

This adds a confirmation dialog if the max score is set to be less than existing student scores.

@dougmartin dougmartin requested a review from lublagg March 7, 2024 11:11
This adds a confirmation dialog if the max score is set to be less than existing student scores.
@dougmartin dougmartin force-pushed the 187021265-add-max-score-alert branch from 61fcb2e to df9ea5b Compare March 7, 2024 11:14
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 12.12121% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 92.21%. Comparing base (0e665b3) to head (df9ea5b).

Files Patch % Lines
...tal-dashboard/feedback/feedback-settings-modal.tsx 9.37% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   92.43%   92.21%   -0.23%     
==========================================
  Files         173      173              
  Lines        6186     6203      +17     
  Branches     1290     1295       +5     
==========================================
+ Hits         5718     5720       +2     
- Misses        443      458      +15     
  Partials       25       25              
Flag Coverage Δ
cypress 90.49% <12.12%> (-0.22%) ⬇️
jest 62.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 7, 2024

Passing run #1795 ↗︎

0 173 5 0 Flakiness 0

Details:

feat: Add confirmation on max score setting [PT-187021265]
Project: portal-report Commit: df9ea5bf55
Status: Passed Duration: 03:29 💡
Started: Mar 7, 2024 11:19 AM Ended: Mar 7, 2024 11:23 AM

Review all test suite changes for PR #445 ↗︎

Copy link
Contributor

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin merged commit 1c26af9 into master Mar 7, 2024
6 of 9 checks passed
@dougmartin dougmartin deleted the 187021265-add-max-score-alert branch March 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants