Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Student report logic for when to show rubric [PT-188024567] #480

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

dougmartin
Copy link
Member

The old logic was preventing the text feedback or score from being shown if the rubric was hidden.

The old logic was preventing the text feedback or score from being shown if the rubric was hidden.
Copy link

cypress bot commented Sep 5, 2024

portal-report    Run #1878

Run Properties:  status check passed Passed #1878  •  git commit cb244cc068: fix: Student report logic for when to show rubric [PT-188024567]
Project portal-report
Branch Review 188024567-fix-show-rubric-conditional
Run status status check passed Passed #1878
Run duration 03m 45s
Commit git commit cb244cc068: fix: Student report logic for when to show rubric [PT-188024567]
Committer Doug Martin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 187
View all changes introduced in this branch ↗︎

Copy link
Member

@pjanik pjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dougmartin dougmartin merged commit 4d7455c into master Sep 5, 2024
7 checks passed
@dougmartin dougmartin deleted the 188024567-fix-show-rubric-conditional branch September 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants