-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore unused inputs when checking validity and change build process #90
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 71.43% 71.31% -0.13%
==========================================
Files 46 46
Lines 1257 1248 -9
Branches 289 290 +1
==========================================
- Hits 898 890 -8
+ Misses 344 343 -1
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
@tealefristoe @scytacki all the build process changes have been added to this PR. It could use an additional review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't pretend to understand all the changes to the build system here, but from what I could tell it looks good. -19750 lines... that's a number I like to see!
@bgoldowsky , is there any area that you'd recommend for regression testing? Since this is a huge PR, I'd appreciate it if you could give some pointers for focusing testing. I have checked the adding/inserting/editing variables directly and from their dialogs, adding/deleting connections, units and the behaviour of the output variables when adding connections which has the bug that this PR is trying to fix. Anything else you can think of? |
@tejal-shah Other than the fix to the PT issue linked in the description, this does not change any functional code, just the process by which the library is built and embedded into CLUE. So my best guess would be to spot check a few things in each general area:
|
@bgoldowsky , thank you, this is very helpful. I've now completed testing and we should be able to merge this in. I'm not hitting the merge button since I'm not sure if there's anything else remaining here or if someone else needs to approve it. Please feel free to merge as you see fit. |
Fixes PT-186817666
The bug report corresponded to a TODO in the file. Instead of bailing out any time an input has no value, first check whether that input is actually used.
This PR also includes a revised build process, which is PT-186892220.
rollup
is no longer used; instead we just usetsc
to compile the Typescript and copy auxilliary files into thedist
directory. The resulting package is not bundled at all; it is assumed that clients (like CLUE) already have their own bundling process that will take care of the SCSS files, minifying Javascript, etc.Package version number changed to 1.0.0-beta.1 to signal the significant change. Once this is better tested, we can remove the beta label.