Add github url to metadata if origin is github. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Johansson <simon@simonjohansson.com>
simonjohansson
force-pushed
the
urlInMetadata
branch
from
a025e3e to
58a6b04
Compare
|
https://ci.concourse-ci.org/teams/resources/pipelines/git/jobs/prs-ubuntu/builds/46 is not due to the PR but network.. Anyways, ping pong. |
vito
approved these changes
Aug 29, 2019
Signed-off-by: Simon Johansson <simon@simonjohansson.com>
|
Cleaned up a bit. Couple the last two tests to the implementation, but in this case I think its alright. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common complaint in our org is that its annoying to go from a build to Github.
Normal workflow is
fly get-pipeline | egrep 'uri|branch'This is a spikey implementation of a fix, if yall agree Ill clean it up a bit.
Also, somewhat fixes #178