Add support for building OCI multi-arch images #93
Conversation
rdrgmnzs
force-pushed
the
multi-arch
branch
3 times, most recently
from
213f8f6 to
45e59b0
Compare
|
Could you add test coverage for the load OCI image method? thx! |
|
Do we need to add notes to Also, thanks @rdrgmnzs for taking this on!!! |
| @@ -69,6 +69,8 @@ type Config struct { | |||
| // Theoretically this would go away if/when we standardize on OCI. | |||
| UnpackRootfs bool `json:"unpack_rootfs" envconfig:"optional"` | |||
|
|
|||
| OutputOCI bool `json:"output_oci" envconfig:"optional"` | |||
rdrgmnzs
force-pushed
the
multi-arch
branch
14 times, most recently
from
336cbbf to
5369216
Compare
Signed-off-by: Rodrigo Menezes <brdude@gmail.com>
|
@xtremerui test added and docs updated! |
| desc := im.Manifests[0] | ||
| ii, err := l.ImageIndex(desc.Digest) | ||
| s.NoError(err) | ||
|
|
||
| images, err := ii.IndexManifest() | ||
| s.NoError(err) |
There was a problem hiding this comment.
desc := im.Manifests[0]
ii, err := l.ImageIndex(desc.Digest)
s.NoError(err)
images, err := ii.IndexManifest()
s.NoError(err)
is this part necessary since im at line 609 is already IndexManifext? Could it use im instead of images at line 621?
There was a problem hiding this comment.
@xtremerui unfortunately it is, I was very confused by this at first as well. The first IndexManifest is for the bundle it self, you then provide the "Digest" of that bundle to get it's index and then you retrieve that manifest using IndexManifest and that's where the data for all the images (multiple images because of multiple CPU architectures) is contained.
When I was figuring this out I actually added print statements to the test, here's a sample output from that so you can see how they differ:
Contents of im: &{SchemaVersion:2 MediaType: Manifests:[{MediaType:application/vnd.oci.image.index.v1+json Size:703 Digest:sha256:1e0d02719eea72a55306e7d55d9d84b6ac25c3ac5705e0d78d72f26eee18e649 Data:[] URLs:[] Annotations:map[org.opencontainers.image.created:2022-07-13T16:48:31Z] Platform:<nil>}] Annotations:map[]}
Contents of images: &{SchemaVersion:2 MediaType:application/vnd.oci.image.index.v1+json Manifests:[{MediaType:application/vnd.oci.image.manifest.v1+json Size:710 Digest:sha256:a6f9c6d46f97a85ace889664bc42437cff0e59c769b02629d98470378ff659d0 Data:[] URLs:[] Annotations:map[] Platform:linux/arm64} {MediaType:application/vnd.oci.image.manifest.v1+json Size:710 Digest:sha256:84b4c953792a04908939367e04c74baa03d8e4f2e701b1c3aa20751e9d286089 Data:[] URLs:[] Annotations:map[] Platform:linux/amd64}] Annotations:map[]}
|
@xtremerui when is this planned to be released? Would really love to be able to use this feature :) |
|
@hugohjerten-spire new release is out! |
Add support for building OCI multi-arch images
It should work in conjunction with the work on concourse/registry-image-resource#321
Signed-off-by: Rodrigo Menezes brdude@gmail.com