Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention to version being cache in the resource #59

Closed
wants to merge 1 commit into from

Conversation

daniellavoie
Copy link

With git driver, manually updating the version value from the version file
does not magically update the next version that will be used since the
ongoing version is cached in the concourse resource.

With git driver, manually updating the version value from the version file
does not magically update the next version that will be used since the
ongoing version is cached in the concourse resource.
@vito
Copy link
Member

vito commented May 29, 2018

Thanks for submitting this! Sorry for the delay in review.

This is actually true of all drivers, not just git. The semantics are a bit nuanced than just a cache though: if a version is updated out-of-band, that doesn't change the fact that prior versions existed and were used for builds, so they're actually preserved so that all that metadata doesn't go away. Maybe with concourse/rfcs#1 we could mark them 'deleted' somehow, though that's kind of tricky...

Maybe we could document something saying that when using this resource, the history in the pipeline is the "source of truth", and the driver is only used for persisting the current version so that it's preserved when the pipeline is moved elsewhere or recreated. It's been a long time since you submitted this, so if you're no longer interested in updating the README to that affect, I don't blame ya.

The semantics (ha) of this resource may change even more with concourse/concourse#1707.

@vito vito closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants