Windows

[lidavidm]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[WillAyd]

Assuming we need to be passing /WX to MSVC instead of /Werror; surprised CMake doesn't already handle this for us

[lidavidm]

So that is actually due to Go. Go is invoking cl for us and it's translating our flags like Werror into /Werror automagically. I remember running into this before and I think it's easiest to force Go to invoke mingw-gcc

I realized when I got here that I've done half of this before:
apache/arrow-adbc#634

So I think the next step here is to add a patch to GoUtils.cmake to set CC/CXX only for Go, and add mingw-gcc to the deps on windows. The issue there notes that the tests won't build/link, but that's OK for our purposes here.

[WillAyd]

Very interesting. Definitely not a conda thing either right? I've always found the environment variables set by activation of a conda environment to be surprising...not something I looked into here just food for thought

[lidavidm]

I don't think it's Conda-specific, I think we just don't do enough testing on Windows due to my own antipathy/lack of a Windows machine

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.