-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows #17
base: main
Are you sure you want to change the base?
Windows #17
Conversation
…nda-forge-pinning 2023.10.03.16.12.15
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Assuming we need to be passing |
So that is actually due to Go. Go is invoking cl for us and it's translating our flags like Werror into /Werror automagically. I remember running into this before and I think it's easiest to force Go to invoke mingw-gcc I realized when I got here that I've done half of this before: So I think the next step here is to add a patch to GoUtils.cmake to set CC/CXX only for Go, and add mingw-gcc to the deps on windows. The issue there notes that the tests won't build/link, but that's OK for our purposes here. |
Very interesting. Definitely not a conda thing either right? I've always found the environment variables set by activation of a conda environment to be surprising...not something I looked into here just food for thought |
I don't think it's Conda-specific, I think we just don't do enough testing on Windows due to my own antipathy/lack of a Windows machine |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)