Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 7.2.1 #236

Merged
merged 21 commits into from
Jul 8, 2024
Merged

bazel 7.2.1 #236

merged 21 commits into from
Jul 8, 2024

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jun 27, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Jul 4, 2024

@h-vetinari I'll cleanup the patches later today and would skip ppc64le if I don't get it running by the end of the day. If someone really wants it, they need to put in the effort.

@h-vetinari
Copy link
Member

That sounds great to me, thanks a lot! Could you perhaps leave a comment in the PR or in the code somewhere what you've learned (or suspect) about the situation on ppc?

third_party/systemlibs/protobuf/BUILD | 4 +-
third_party/systemlibs/protobuf/MODULE.bazel | 12 +-
.../systemlibs/protobuf/java/core/BUILD | 6 +
.../protobuf/maven_protobuf_install.json | 2572 +++++++++++++++++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave a comment how this file is supposed to be generated? Also, if easily automatable, perhaps it would be easier to download/generate this json on the fly in the build script, rather than copy it in via a patch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to switch to generation in the build script before I merge.

@xhochy xhochy merged commit fe51f15 into conda-forge:main Jul 8, 2024
7 checks passed
@xhochy xhochy deleted the 7.2.1 branch July 8, 2024 14:10
@h-vetinari h-vetinari mentioned this pull request Jul 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants