Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crosstool_wrapper_driver_is_not_gcc #12

Closed
wants to merge 6 commits into from

Conversation

ngam
Copy link

@ngam ngam commented Aug 6, 2022

Minor updates following upstream.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ngam ngam requested review from wolfv and xhochy as code owners August 6, 2022 15:29
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam
Copy link
Author

ngam commented Aug 6, 2022

@conda-forge-admin, please rerender

@ngam
Copy link
Author

ngam commented Aug 6, 2022

@xhochy @wolfv could you please review and see if other changes are needed? These are minor, but I suspect more changes on the jaxlib and tensorflow ends require more updates here. I am having trouble tracing all of this down and updating this feedstock may help. Note a lot of changes took place on the jaxlib and tensorflow ends lately, especially on the front of updating things to c++17

xref:
conda-forge/tensorflow-feedstock#262
conda-forge/tensorflow-feedstock#261
conda-forge/tensorflow-feedstock#260
conda-forge/jaxlib-feedstock#122

ngam added a commit to ngam/tensorflow-feedstock that referenced this pull request Aug 6, 2022
recipe/meta.yaml Outdated
@@ -1,5 +1,5 @@
{% set name = "bazel-toolchain" %}
{% set version = "0.1.5" %}
{% set version = "0.2.5" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to reset the patch version when bumping minor?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. No idea what I was doing! Do you think bumping the minor here is warranted anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think bumping the minor here is warranted anyway?

No idea; I had assumed it was intentional. Something for @conda-forge/bazel-toolchain to decide...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/bazel-toolchain-feedstock/actions/runs/2983160143.

@ngam
Copy link
Author

ngam commented Sep 24, 2022

Closing after weeks with no response...

@ngam ngam closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants