Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove libboost run-export from libboost-python-devel #189

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jan 27, 2024

In preparation for the 1.84 migration, which fixes this aspect of the 1.82 migration (c.f. #176)

Closes #191

packages depending on libboost should add a host-dependency on
libboost-devel directly.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jan 27, 2024
Copy link
Contributor

github-actions bot commented Jan 27, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Jan 28, 2024
@h-vetinari
Copy link
Member Author

$PREFIX/x86_64-conda-linux-gnu/bin/ld: warning: libz.so.1, needed by $PREFIX/lib/libboost_iostreams.so, not found (try using -rpath or -rpath-link)

No idea why the old test_lib.sh started failing on linux, nor why libz.so.1 isn't found even though it's definitely in the test environment.

  environment location: /home/conda/feedstock_root/build_artifacts/boost-split_1706514658426/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac


The following NEW packages will be INSTALLED:

    _libgcc_mutex:            0.1-conda_forge     conda-forge
    _openmp_mutex:            4.5-2_gnu           conda-forge
    binutils_impl_linux-64:   2.40-hf600244_0     conda-forge
    binutils_linux-64:        2.40-hbdbef99_2     conda-forge
    bzip2:                    1.0.8-hd590300_5    conda-forge
    gcc_impl_linux-64:        12.3.0-he2b93b0_4   conda-forge
    gcc_linux-64:             12.3.0-h76fc315_2   conda-forge
    gxx_impl_linux-64:        12.3.0-he2b93b0_4   conda-forge
    gxx_linux-64:             12.3.0-h8a814eb_2   conda-forge
    icu:                      73.2-h59595ed_0     conda-forge
    kernel-headers_linux-64:  2.6.32-he073ed8_16  conda-forge
    ld_impl_linux-64:         2.40-h41732ed_0     conda-forge
    libboost:                 1.84.0-h8013b2b_1   local      
    libboost-devel:           1.84.0-h00ab1b0_1   local      
    libboost-headers:         1.84.0-ha770c72_1   local      
    libgcc-devel_linux-64:    12.3.0-h8bca6fd_104 conda-forge
    libgcc-ng:                13.2.0-h807b86a_4   conda-forge
    libgomp:                  13.2.0-h807b86a_4   conda-forge
    libsanitizer:             12.3.0-h0f45ef3_4   conda-forge
    libstdcxx-devel_linux-64: 12.3.0-h8bca6fd_104 conda-forge
    libstdcxx-ng:             13.2.0-h7e041cc_4   conda-forge
    libzlib:                  1.2.13-hd590300_5   conda-forge
    sysroot_linux-64:         2.12-he073ed8_16    conda-forge
    xz:                       5.2.6-h166bdaf_0    conda-forge
    zstd:                     1.5.5-hfc55251_0    conda-forge

@h-vetinari
Copy link
Member Author

@conda-forge/boost
Not sure what's happening here that broke the recipe (see also a vanilla rerun of current main in #191); the linker cannot find the compression libraries that are clearly in the environment, which is also specified in the linker-argument:

# Test boost::iostreams zlib filter support
cd test
${CXX} -I$PREFIX/include -L$PREFIX/lib -Wl,-rpath,$PREFIX/lib test_iostreams_zlib.cpp -lboost_iostreams && ./a.out

In particular, we're already doing what the error tells us to do:

$PREFIX/x86_64-conda-linux-gnu/bin/ld: warning: libz.so.1, needed by $PREFIX/lib/libboost_iostreams.so, not found (try using -rpath or -rpath-link)

Adding -lbz2 -llzma -lzstd on that line does help, but zlib does not get found even with -lz; this may be because, as the comment notes, it's only the zlib integration that's being tested here.

@h-vetinari
Copy link
Member Author

Not sure what's happening here that broke the recipe

OK, lucky timinig/coincidence for me to see this comment where @mbargull rootcaused a bug in conda-build 3.28 involving rpaths. Seems that we're also corrupting our rpath metadata here somehow, because things build fine with conda-build 3.27.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 13, 2024
@github-actions github-actions bot merged commit 80f2862 into conda-forge:main Feb 13, 2024
8 checks passed
@h-vetinari h-vetinari deleted the run branch February 13, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant