Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for LLVM 17 #62

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Build for LLVM 17 #62

merged 6 commits into from
Oct 12, 2023

Conversation

h-vetinari
Copy link
Member

Let's do the version upgrade separately, this is just enablement for LLVM 17 or now

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Oct 6, 2023
Merged
11 tasks
@h-vetinari
Copy link
Member Author

@conda-forge/cctools-and-ld64, this is ready for review!

Since we don't have separate branches between versions here, this review should reasonably include #61 as well, though the only relevant addition there is e21b872, which is intended to ensure that we're not trying to use anything related to LLVM 17 on a too-old MacOS.

xhochy
xhochy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detected file renames of .ci_support are a bit weird but I have looked into the files and everything seems fine 👍

@h-vetinari
Copy link
Member Author

The detected file renames of .ci_support are a bit weird but I have looked into the files and everything seems fine 👍

That's because we dropped the zip with llvm_version / channel sources etc.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 12, 2023 •
edited
Loading

Given how many feedstocks are currently forced to downgrade to clang 15, I'm going to reinstate support here for the time being.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Oct 12, 2023
@github-actions github-actions bot merged commit ae27d07 into conda-forge:main Oct 12, 2023
20 checks passed
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the 17 branch October 12, 2023 01:39
@h-vetinari h-vetinari mentioned this pull request Oct 12, 2023
Merged
@h-vetinari h-vetinari changed the title LLVM 17.0.2 Build for LLVM 17 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@davidbrochart davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@katietz katietz Awaiting requested review from katietz katietz is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @xhochy