Skip to content

Commit

Permalink
adapt LIBCLANG_SOVERSION_ARG to work on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
h-vetinari committed Feb 5, 2023
1 parent 7a7f1a6 commit 3ec92c1
Showing 1 changed file with 16 additions and 6 deletions.
22 changes: 16 additions & 6 deletions recipe/patches/0008-set-libclang-SOVERSION-unconditionally.patch
Original file line number Diff line number Diff line change
@@ -1,25 +1,35 @@
From 4bc14803d5047c88ab177138e0bc63592d459185 Mon Sep 17 00:00:00 2001
From 05b1d7d8e52a23a32a25ea8c1aa7a4676ddc0a8f Mon Sep 17 00:00:00 2001
From: "H. Vetinari" <h.vetinari@gmx.com>
Date: Thu, 14 Apr 2022 11:57:00 +1100
Subject: [PATCH 8/8] set libclang SOVERSION unconditionally

---
clang/tools/libclang/CMakeLists.txt | 6 ++++++
1 file changed, 6 insertions(+)
clang/tools/libclang/CMakeLists.txt | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt
index da8a9740fa..d311440695 100644
index da8a9740fa..998e657b6a 100644
--- a/clang/tools/libclang/CMakeLists.txt
+++ b/clang/tools/libclang/CMakeLists.txt
@@ -199,7 +199,13 @@ if(ENABLE_SHARED)
@@ -11,7 +11,8 @@
# in LLVM 15.x we opted for a option.
set(LIBCLANG_SOVERSION_ARG)
if(NOT CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION)
- set(LIBCLANG_SOVERSION_ARG SOVERSION 13)
+ set(LIBCLANG_SOVERSION 13)
+ set(LIBCLANG_SOVERSION_ARG SOVERSION ${LIBCLANG_SOVERSION})
endif()

# TODO: harmonize usage of LIBCLANG_SOVERSION / LIBCLANG_LIBARY_VERSION
@@ -199,7 +200,13 @@ if(ENABLE_SHARED)
# Ensure that libclang.so gets rebuilt when the linker script changes.
set_property(SOURCE ARCMigrate.cpp APPEND PROPERTY
OBJECT_DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map)
+ endif()

+ if(WIN32)
+ # point libclang.lib to libclang-<SO-version>.dll
+ set_target_properties(libclang PROPERTIES RUNTIME_OUTPUT_NAME "libclang-${LIBCLANG_SOVERSION_ARG}")
+ set_target_properties(libclang PROPERTIES RUNTIME_OUTPUT_NAME "libclang-${LIBCLANG_SOVERSION}")
+ else()
+ # on unix, set so-version directly
set_target_properties(libclang PROPERTIES
Expand Down

0 comments on commit 3ec92c1

Please sign in to comment.