Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerenders fail with 'TARGET_OS_TV' is not defined #116

Closed
xhochy opened this issue Nov 17, 2020 · 0 comments · Fixed by #117
Closed

Rerenders fail with 'TARGET_OS_TV' is not defined #116

xhochy opened this issue Nov 17, 2020 · 0 comments · Fixed by #117

Comments

@xhochy
Copy link
Member

xhochy commented Nov 17, 2020

I see a lot of projects failing with the following error with clang=11 on osx-64:

error: 'TARGET_OS_TV' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
#if !(defined(__APPLE__) && (TARGET_OS_TV || TARGET_OS_WATCH))

See Azure build for nodejs PR as an example.

This is because we are still on the 10.9 SDK which doesn't come with a corresponding TargetConditionals.h header. The 11 SDK has the corresponding header and thus the jobs don't fail there.

This is a hard -Werror failure baked into clang that cannot be deactivated easily by the user https://github.com/llvm/llvm-project/blob/176249bd6732a8044d457092ed932768724a6f06/clang/lib/Driver/ToolChains/Darwin.cpp#L961-L964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant