Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -Werror,-Wundef-prefix=TARGET_OS as they are not yet defined in the 10.9 SDK used for osx-64 #117

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Nov 17, 2020

Fixes #116

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to at least keep the warning for TARGET_OS_OSX

@xhochy
Copy link
Member Author

xhochy commented Nov 17, 2020

TARGET_OS_OSX

Why? This is neither defined in my local copy of the 10.9 SDK.

@isuruf
Copy link
Member

isuruf commented Nov 17, 2020

This is neither defined in my local copy of the 10.9 SDK.

Sure, but if some package is depending on TARGET_OS_OSX, we shouldn't ignore the warning. I think that's the whole reason for adding this warning.

@isuruf isuruf merged commit 234a25c into conda-forge:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerenders fail with 'TARGET_OS_TV' is not defined
3 participants