Add an additional OSX_SDK_DIR for newer macOS images on Azure #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…da-forge-pinning 2020.10.13.19.09.25
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
mbargull
commented
Oct 14, 2020
| export OSX_SDK_DIR=/Applications/Xcode_12_beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs | ||
| export OSX_SDK_DIR=/Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs | ||
| if [[ ! -d "${OSX_SDK_DIR}" ]]; then | ||
| export OSX_SDK_DIR=/Applications/Xcode_12_beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs |
There was a problem hiding this comment.
I retained this one just in case an older image could be used.
This can be removed in the future.
chrisburr
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
I was just about to do this as it's affecting conda-forge/clangdev-feedstock#106 as well
|
Let's wait for @isuruf but lgtm! |
5 tasks
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Add an additional
OSX_SDK_DIRfor newer macOS images on Azure.ref: conda-forge/python-feedstock#402 (comment)