-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document OS-specific approaches for noarch packages #1839
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8af376f
Document OS-specific approaches for noarch packages
jaimergp c33f553
fix label
jaimergp d17fb46
fix yaml blocks
jaimergp 99af8f6
add details about build string
jaimergp fa8b4ec
use yaml+jinja
jaimergp 8dbc5e4
rephrase and rewrap
jaimergp a893f82
noarch_platforms uses underscores
jaimergp 00ecadc
use selectors and get rid of conda_build_config indirection
jaimergp b43e58b
Update src/maintainer/knowledge_base.rst
jaimergp 6e93d0b
Update knowledge_base.rst
jaimergp 7b58e00
Lower bound on python
isuruf ca54541
Remove hashes for conda-build 3.25.0
isuruf 0340b8b
missing space
jaimergp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to avoid manipulating the
string
and instead rely on different hashes (note Jaime is mentioning something similar elsewhere)?The main issue with
string
is pretty finicky. Users need to be very careful to replicate conda-build's behavior and if they missing something they could wind up with duplicate packages (which sometimes can both be accepted by Anaconda.org with neither being downloadable).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be needed until conda/conda-build#4606 lands and a new conda-build release is cut.
Is it ok to merge as is or would you rather have a little admonition mentioning this caveat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding from the thread above is using
conda_build_config.yaml
meant we would not need this.Fixing conda-build to not need either is certainly better. That said, between setting a
string
and usingconda_build_config.yaml
, would prefer the latter (fewer foot guns).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am partial to
conda_build_config.yaml
too as we transition to the new conda-build version.