Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add announcement for dropping MacOS<10.13 #1993

Merged
merged 11 commits into from
Aug 23, 2023
Merged

Conversation

h-vetinari
Copy link
Member

First step according to the TODO List here.

While the stance of upstream CPython does not affect our infrastructure & metadata per se, it's worth noting that discussion on DPO started by @jakirkham to this effect is still fresh, and it sounds like CPython will also upgrade "in the not too distant future", and might jump even further (e.g. 10.15 or 11.0). We can still choose to follow suit with such a step later on, but moving to 10.13 now is (effectively) necessary to unblock abseil, grpc, protobuf, (and soon) libcxx etc., so IMO we shouldn't wait for however long CPython takes to come to a decision on that.

I've added a second commit that clarifies our support stance (pointing out how it is "best effort"), but I can drop that if anyone disagrees.

@h-vetinari h-vetinari requested a review from a team as a code owner August 20, 2023 02:18
src/user/announcements.rst Outdated Show resolved Hide resolved
src/user/announcements.rst Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

I agree the tone of the note is a bit negative / off putting at times.

@h-vetinari
Copy link
Member Author

I agree the tone of the note is a bit negative / off putting at times.

Happy to reformulate however people wish to

@h-vetinari
Copy link
Member Author

Any concrete suggestions how to improve the text @beckermr?

@pkgw, hope your question has been addressed? As I said this is not setting a policy, but we can discuss whether there's appetite for that in the core call.

@beckermr
Copy link
Member

I'll send some changes. Sorry for the comment and then delay in taking any action.

@pkgw
Copy link
Contributor

pkgw commented Aug 22, 2023

@h-vetinari My only further suggestion is that the body text should explicitly mention the new minimum version, to go along with what's in the title.

@hmaarrfk
Copy link
Contributor

would it be possible to write down the years in which these key versions were released?

@beckermr
Copy link
Member

Very sorry. Will send comments tonight. Back to school is tomorrow for my kids. It's a bit crazy. If you absolutely need to go ahead, feel free to.

@h-vetinari
Copy link
Member Author

No stress. I've set the day to the 24th for now. 1-2 days are also not going to matter.

The only real advantage of wrapping this up before the core call is that we could deprioritize it if other topics on the agenda are more important (than discussing a possible longer-term MacOS support policy).

h-vetinari and others added 2 commits August 23, 2023 04:37
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
@beckermr beckermr merged commit d783c10 into conda-forge:main Aug 23, 2023
1 check passed
@h-vetinari h-vetinari deleted the macos branch August 23, 2023 17:03
@dell-datascience
Copy link

in my quest to install apache airflow, i encountered this error which led me here. I hear it has something to do with MACOS-10.9. any headway yet?

this is the error:

Building wheels for collected packages: google-re2, pendulum
Building wheel for google-re2 (setup.py) ... error
error: subprocess-exited-with-error

× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [15 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build/lib.macosx-10.9-x86_64-cpython-311
copying re2.py -> build/lib.macosx-10.9-x86_64-cpython-311
running build_ext
building '_re2' extension
creating build/temp.macosx-10.9-x86_64-cpython-311
clang -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/air/anaconda3/envs/super/include -fPIC -O2 -isystem /Users/air/anaconda3/envs/super/include -I/usr/local/opt/readline/include -I/Users/air/anaconda3/envs/super/include/python3.11 -c _re2.cc -o build/temp.macosx-10.9-x86_64-cpython-311/_re2.o -fvisibility=hidden
_re2.cc:11:10: fatal error: 'pybind11/pybind11.h' file not found
#include <pybind11/pybind11.h>
^~~~~~~~~~~~~~~~~~~~~
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for google-re2
Running setup.py clean for google-re2
Building wheel for pendulum (pyproject.toml) ... done
Created wheel for pendulum: filename=pendulum-2.1.2-cp311-cp311-macosx_11_0_x86_64.whl size=124681 sha256=9d9ae2fbf4746efb4fc52ea8cfabad1891b7b5971cdbaf5cea6c0e59a9c3e8a0
Stored in directory: /Users/air/Library/Caches/pip/wheels/a4/b7/10/a86f4f49b1bdf8a0cf3da42d48f499e4cb7529ebab7aad3550
Successfully built pendulum
Failed to build google-re2
ERROR: Could not build wheels for google-re2, which is required to install pyproject.toml-based projects

jaimergp added a commit to jaimergp/conda-forge.github.io that referenced this pull request Jan 10, 2024
conda-forge#1993

Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants