Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to find NumPy with CMake on cross-compiled builds #2321

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Document how to find NumPy with CMake on cross-compiled builds #2321

merged 3 commits into from
Nov 19, 2024

Conversation

traversaro
Copy link
Contributor

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

Proposal to fix #2260 .

@traversaro traversaro requested a review from a team as a code owner October 1, 2024 10:40
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 9bc3bc4
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/66fd021b381c3400085be289
😎 Deploy Preview https://deploy-preview-2321--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@traversaro traversaro mentioned this pull request Oct 1, 2024
Closed
@traversaro
Copy link
Contributor Author

pre-commit.ci autofix

@traversaro traversaro mentioned this pull request Oct 30, 2024
Merged
@traversaro traversaro mentioned this pull request Nov 11, 2024
Merged
5 tasks
@traversaro traversaro requested a review from jaimergp November 17, 2024 10:24
@traversaro
Copy link
Contributor Author

Sorry @jaimergp, I just realized I never asked again the review after I address your comment.

jaimergp
jaimergp approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have the background to assess whether this is the right solution or not. Judging by the discussion in #2260 it looks like the best effort so far, so I'm inclined to merge regardless. I'll leave it open for a couple days before doing so in case someone from @conda-forge/core wants to chime in.

@traversaro
Copy link
Contributor Author

LGTM but I don't have the background to assess whether this is the right solution or not.

That is correct. My feeling is that probably there should be something that may be fixed in cmake and/or conda-forge cross-compilation setuptools to avoid the need to manually set this include directories, but I was not able to identify this.

@hmaarrfk hmaarrfk merged commit fb5daac into conda-forge:main Nov 19, 2024
6 checks passed
@hmaarrfk
Copy link
Contributor

Let’s merge and iterate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to handle problems with CMake finding NumPy in cross-compilation
3 participants
@traversaro @hmaarrfk @jaimergp