Move ulimit workaround into yum reqs func
#1961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
mv_ulimit_yum_gen_func
branch
from
d405f43
to
1765e96
Compare
|
Testing this out in PR: conda-forge/python-feedstock#691 |
jakirkham
force-pushed
the
mv_ulimit_yum_gen_func
branch
from
1765e96
to
29516af
Compare
1 task
beckermr
approved these changes
Jun 24, 2024
isuruf
reviewed
Jun 25, 2024
Comment on lines
+1361
to
+1365
| # Due to https://bugzilla.redhat.com/show_bug.cgi?id=1537564 old | ||
| # versions of rpm are drastically slowed down when the number of | ||
| # file descriptors is very high. This can be visible during a | ||
| # `yum install` step of a feedstock build. | ||
| # => Set a lower limit in a subshell for the `yum install`s only. |
There was a problem hiding this comment.
Let's keep this explanation in conda-smithy. No need to propagate it to each and every feedstock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
ulimitworkaround used withyumadded in PR ( #1960 ) into thegenerate_yum_requirementsfunction per this suggestion ( #1960 (comment) ).In the process this also fixes a formatting issue that occurs when cleaning up blank space with Jinja.
Checklist
AddedUpdated anewsentry