Build shared libraries, add run-export #44
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
shared
branch
4 times, most recently
from
194a15b
to
a0fa312
Compare
…nda-forge-pinning 2023.04.27.08.32.08
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@lidavidm @wjones127 |
| * @h-vetinari @lidavidm |
There was a problem hiding this comment.
It sounds like @lidavidm will need to grant you write access to the repo if you want to be added as a codeowner.
There was a problem hiding this comment.
That warning is just GitHub being silly. Merging the PR is all that's necessary to join as a maintainer.
| @@ -15,6 +15,8 @@ cmake .. ^ | |||
| -DCMAKE_CXX_STANDARD=17 ^ | |||
| -DCMAKE_PREFIX_PATH=%CONDA_PREFIX% ^ | |||
| -DCMAKE_INSTALL_PREFIX=%LIBRARY_PREFIX% ^ | |||
| -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON ^ | |||
There was a problem hiding this comment.
Seems like this may need to be fixed upstream (presumably dllimport/dllexport annotations are missing)?
There was a problem hiding this comment.
Yes, but those are really invasive and that's why many projects don't have them 🤷
There was a problem hiding this comment.
more practically, google never fixed the protobuf compiler to be able to insert them properly so I guess it's not possible to fix anyways. (at least the last time I took a swing at that.)
|
Thanks for merging! :) |
... though I wish you hadn't squashed everything. 🤷 Makes it harder to do archeology etc. on the feedstock. |
|
Ah sorry, it appears to default to squash for me and usually I just go with that. I'll try to keep that in mind. |
Towards #38
Closes #41