Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build API here as well; rename to libopentelemetry-cpp{,-headers} #46

Merged
merged 10 commits into from
May 4, 2023

Conversation

h-vetinari
Copy link
Member

As discussed in #38; the api-feedstock can follow separately

Closes #38

The diff here is small when viewed with white-space changes ignored (only indentation increased for the most part; see also per-commit).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@lidavidm @xhochy
Any further comments here?

Copy link
Contributor

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I thought this wasn't ready since it was in draft.

LGTM

@h-vetinari
Copy link
Member Author

Ah, sorry, I thought this wasn't ready since it was in draft.

It was in draft because I wanted to hear people's opinions first. 😅

@h-vetinari h-vetinari marked this pull request as ready for review May 3, 2023 12:14
@h-vetinari
Copy link
Member Author

the api-feedstock can follow separately

Actually, since both -sdk & -api (as currently named) are built from the same sources, why not unify everything in this feedstock? That would make life a whole lot easier in several respects...

@lidavidm
Copy link
Contributor

lidavidm commented May 3, 2023

Sounds good to me. (...to be honest, when I first made these feedstocks, I don't think I realized multi-output recipes were a thing. Packaging for Conda is not something I do much.)

@h-vetinari
Copy link
Member Author

Cool :)

Do you care particularly about the git-history of the api-feedstock? It's possible to import it but a bit messy. (Here's a recent example where the reasons to maintain the history outweigh the hassle & messiness).

@lidavidm
Copy link
Contributor

lidavidm commented May 3, 2023

I don't particularly care, so if it's a hassle I'd rather not bother.

@h-vetinari h-vetinari changed the title Rename to libopentelemetry-cpp Build API here as well; rename to libopentelemetry-cpp{,-headers} May 4, 2023
@h-vetinari
Copy link
Member Author

OK, this is ready for another peek @lidavidm. Basically I'm planning to merge it as soon as conda-forge/feedstock-outputs#46 is in.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, otherwise: nice!

recipe/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@h-vetinari h-vetinari merged commit 4484d04 into conda-forge:main May 4, 2023
@h-vetinari h-vetinari deleted the lib branch May 4, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build shared libs, add run-export, register in global pinning
3 participants