-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build API here as well; rename to libopentelemetry-cpp{,-headers} #46
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I thought this wasn't ready since it was in draft.
LGTM
It was in draft because I wanted to hear people's opinions first. 😅 |
Actually, since both |
Sounds good to me. (...to be honest, when I first made these feedstocks, I don't think I realized multi-output recipes were a thing. Packaging for Conda is not something I do much.) |
Cool :) Do you care particularly about the git-history of the api-feedstock? It's possible to import it but a bit messy. (Here's a recent example where the reasons to maintain the history outweigh the hassle & messiness). |
I don't particularly care, so if it's a hassle I'd rather not bother. |
e63a9cd
to
aeb7398
Compare
remove unnecessary indirection & complication, use common indentation & invocation patterns no functional changes, mostly indentation shifts
…nda-forge-pinning 2023.05.03.22.46.04
OK, this is ready for another peek @lidavidm. Basically I'm planning to merge it as soon as conda-forge/feedstock-outputs#46 is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit, otherwise: nice!
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
As discussed in #38; the api-feedstock can follow separately
Closes #38
The diff here is small when viewed with white-space changes ignored (only indentation increased for the most part; see also per-commit).