Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require libcxx without modified header guards #61

Closed
wants to merge 3 commits into from

Conversation

saraedum
Copy link
Member

This is a workaround for conda-forge/cppyy-feedstock#78.

We also need to make this same change for all the previous builds for macOS.

@saraedum saraedum requested a review from isuruf as a code owner June 12, 2024 00:27
@conda-forge-webservices

This comment was marked as outdated.

@conda-forge-webservices

This comment was marked as outdated.

@conda-forge-webservices

This comment was marked as outdated.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@saraedum
Copy link
Member Author

This will probably then break again when xcode 16 is released with its llvm 17.
I think there is not much we can do about this. Basically, we need the user to install a libcxx that is compatible with their xcode. I don't think we can patch such a requirement into the existing builds of cppyy-clang somehow.
Maybe better than breaking this for future users of old versions of cppyy is to just document this in an issue here.

@saraedum saraedum closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant