Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the alma images have different names #242

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 10, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team October 10, 2023 04:51
@jakirkham
Copy link
Member

The original idea here was to use a multiarch image. It's possible there's some else still need to make that work well. Am happy to take a look if needed

@isuruf
Copy link
Member Author

isuruf commented Oct 10, 2023

It doesn't work at the moment. We only use the docker image name in conda-smithy and just saying linux-anvil-alma would bring in arm64 image on a x86_64 runner. Also when emulating the full system, we need to be able to say we need the ppc64le docker image on the x86_64 runner which is not possible right now as well.

@xhochy
Copy link
Member

xhochy commented Oct 10, 2023

This could be done by also passing in the --platform switch on docker run to select the underlying architecture but this didn't work well for me in the past. It often fell back to the native architecture when I had selected a non-native/emulated one. Using the sha256 digest works reliably to select non-native platforms but I don't see a way to transfer that easily into our build scripts.

Thus I'm also in favour of this PR as it keeps the images easily distinguishable and works very reliable in selecting the execution architecture.

@isuruf
Copy link
Member Author

isuruf commented Oct 13, 2023

Ping on this @jakirkham

@isuruf
Copy link
Member Author

isuruf commented Oct 30, 2023

Ping

@isuruf isuruf merged commit 7f450a4 into conda-forge:main Nov 2, 2023
33 of 34 checks passed
@isuruf isuruf deleted the alma branch November 2, 2023 13:56
@mbargull mbargull mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants