Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate RC1 esmvalcore=2.8.1rc1 #62

Merged
merged 6 commits into from
May 19, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 19, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
    * [ ] Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@valeriupredoi
Copy link
Contributor Author

@conda-forge-admin, please rerender

@valeriupredoi
Copy link
Contributor Author

@bouweandela I noticed we have a set of quite restrictive (well, lower bounds) pins for a number of packages from the pytesting zone, and we never bothered plopping those pins in here, shall I bring them in so we are exactly at the same pins as upstream?

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/esmvalcore-feedstock/actions/runs/5025290100.

@bouweandela
Copy link
Contributor

I wouldn't bother unless you run into trouble. By default you'll get the latest of everything anyway.

@valeriupredoi
Copy link
Contributor Author

I wouldn't bother unless you run into trouble. By default you'll get the latest of everything anyway.

yeh that's what I thought too, but now, as a responsible maintainer of various dubious packages across c-f, I thought I'd be a bit more tidy about that 😁

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented May 19, 2023

huzzah! Tests pass - can I get a review please 🍺 build and test session with platform linux -- Python 3.11.3 🐍

@valeriupredoi
Copy link
Contributor Author

@bouweandela you a legend, cheers, bud 🍺

@valeriupredoi valeriupredoi merged commit 24247b6 into conda-forge:rc May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants