Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.11.0.build=1] pin cartopy<0.24 and curl<8.10 and pandas<2.2.0 and change to build 1 #29

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 14, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [ ] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Changes needed via upstream by ESMValGroup/ESMValTool#3768 and ESMValGroup/ESMValTool#3755
Changes tested upstream and plugged in v2.11.x branch via ESMValGroup/ESMValTool#3770
Pandas pinned (hopefully for the last time, upstream ESMValCore fix is now in ESMValGroup/ESMValCore#2529)
Also pinned to Python<3.12 just to be as close as the tested ESMValTool 2.11

@valeriupredoi
Copy link
Contributor Author

@conda-forge-admin, please rerender

@valeriupredoi valeriupredoi changed the title pin cartopy<0.24 and curl<8.10 and change to build 1 [v2.11.0.build=1] pin cartopy<0.24 and curl<8.10 and change to build 1 Oct 14, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • Use importlib-metadata instead of importlib_metadata
  • No valid build backend found for Python recipe for package esmvaltool-python using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@valeriupredoi valeriupredoi changed the title [v2.11.0.build=1] pin cartopy<0.24 and curl<8.10 and change to build 1 [v2.11.0.build=1] pin cartopy<0.24 and curl<8.10 and pandas<2.2.0 and change to build 1 Oct 14, 2024
@schlunma
Copy link
Contributor

For recipe/meta.yaml:

* Use `importlib-metadata` instead of `importlib_metadata`

* No valid build backend found for Python recipe for package `esmvaltool-python` using `pip`. Python recipes using `pip` need to explicitly specify a build backend in the `host` section. If your recipe has built with only `pip` in the `host` section in the past, you likely should add `setuptools` to the `host` section of your recipe.

Do we want to consider these?

@valeriupredoi
Copy link
Contributor Author

For recipe/meta.yaml:

* Use `importlib-metadata` instead of `importlib_metadata`

* No valid build backend found for Python recipe for package `esmvaltool-python` using `pip`. Python recipes using `pip` need to explicitly specify a build backend in the `host` section. If your recipe has built with only `pip` in the `host` section in the past, you likely should add `setuptools` to the `host` section of your recipe.

Do we want to consider these?

no - we don't have an esmvaltool-python PyPI package, and we specifically want to pin importlib_metadata and not the one with dash in it 🍺

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't really like this hard pin on the Python version to be honest, but it's probably safer that way.

I am also still not quite sure if we can really dismiss the comments by @conda-forge-admin so easily, but let's discuss this when we release v2.12.0.

Thanks V for taking care of this!

Copy link

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you asked me to look at it, have an approve 👍
packages are pinned to what was discussed to avoid issues, can't really comment on the comments. Hard pin on python will only be until the next release so should be fine.

@valeriupredoi
Copy link
Contributor Author

oh I absolutely hate the Python<3.12 pin myself, bud, especially now that we have full functionality for it in the main branch - but, I reckon better safe than sorry - we can always come back and rebuild with it, but you know - this way is the closest one can get to the actual 2.11 (bar a lock file that would completely freeze the deps and builds at the moment of 2.11 release).

About what c-f is suggesting - it's not possible, since importlib-metadata is actually a different package https://anaconda.org/conda-forge/importlib_metadata/files vs https://anaconda.org/conda-forge/importlib-metadata/files - not sure myself what the differences between the two pkgs are but, I know fr a fact we need to pin the underscore one 🍺

@valeriupredoi
Copy link
Contributor Author

cheers Manu 🍺

@valeriupredoi
Copy link
Contributor Author

Since you asked me to look at it, have an approve 👍 packages are pinned to what was discussed to avoid issues, can't really comment on the comments. Hard pin on python will only be until the next release so should be fine.

excellent, cheers, Tina 🍺

@valeriupredoi valeriupredoi merged commit 4581a90 into conda-forge:main Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants