Rebuild for fmt 11 #217
Rebuild for fmt 11 #217
Conversation
…nda-forge-pinning 2024.08.13.12.16.38
regro-cf-autotick-bot
requested review from
JohanMabille,
jjerphan,
pearu and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
Due to facebook/folly#2250 with a CMake-specific bug on Windows. |
|
Looking at facebook/folly#2250, could you not simply set |
|
Also, if I understand the CMake bug (and its predecessor) correctly, this is just exposing a problem/misuse that has to exist in either folly or fmt? As in: the failure on windows is correct, and it should also fail on unix. In that case I guess we need to either patch folly or fmt. |
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
Is the I would wait for a patch upstream. |
Kinda, as it's causing boost to pile up behind it (packages that are still on fmt 10 fail to resolve)
The issue is open for ~6 weeks without response. If the patch ends up being easy, we could be the ones testing it here (not necessarily merging), and then proposing it upstream... 🙃 |
|
I currently am busy with something else urgent. I guess the best would be to stop shipping folly for Windows at least temporarily. Edit: I propose to skip Windows' builds, see the reason in the commit message. |
Rationale: Windows was never considered a supported platform of folly. The maintainance of the feedstock for Windows is costly while the use of it is questionable. folly is used by a few projects on conda-forge, some of which aren't distributed for Windows anyway. See: https://github.com/facebook/folly?tab=readme-ov-file#build-notes See: facebook/folly#962 Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.27.11.04.58
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
|
Let's have the bot rerun this PR. |
|
Due to the |
This PR has been triggered in an effort to update fmt11.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10371316762 - please use this URL for debugging.